Refactor code to increase code quality and type coverage #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
increase-type-coverage
branch
from
1f0bced to
c4c59c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1868 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 1765 1764 -1
===========================================
Files 182 182
Lines 4706 4704 -2
===========================================
- Hits 4706 4704 -2 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
increase-type-coverage
branch
from
0e3a388 to
c3edbb6
Compare
caendesilva
changed the title
This reverts commit c3edbb6.
These collections always contain these types, we should be able to get the data from the generics as they're hardcoded
caendesilva
force-pushed
the
increase-type-coverage
branch
from
a150001 to
2e9ab04
Compare
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
force-pushed
the
increase-type-coverage
branch
from
04f8f56 to
6c5159b
Compare
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
force-pushed
the
increase-type-coverage
branch
from
247aec5 to
ba198dc
Compare
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
force-pushed
the
increase-type-coverage
branch
from
69705f4 to
140e38b
Compare
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-1868
GitHub Actions
Inactive
|
Okay, literally impossible for us to get higher type coverage! Only two mixed types left, and those are developer hooks where we actually cannot know the types.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ~200 Psalm issues and brings type coverage from
97.82%to99.97%